footprint wizards: fixes and enhancements

3 years ago · 50502c450f
10 changed files with 43 additions and 18 deletions
--- a/pcbnew/python/plugins/FPC_wizard.py
+++ b/pcbnew/python/plugins/FPC_wizard.py
@ -132,7 +132,7 @@ class FPC_FootprintWizard(FootprintWizardBase.FootprintWizard):
        self.draw.Line(-xstart, posy, -xend, yend)

        # set SMD attribute
-        self.module.SetAttributes(pcbnew.PAD_ATTRIB_SMD)
+        self.module.SetAttributes(pcbnew.FP_SMD)

        # vertical segment at left of the pad
        xstart = xend
--- a/pcbnew/python/plugins/FootprintWizardBase.py
+++ b/pcbnew/python/plugins/FootprintWizardBase.py
@ -603,9 +603,10 @@ class FootprintWizardDrawingAids:
            for i in range(0, len(pts) - 1):
                self.Line(pts[i][0], pts[i][1], pts[i+1][0], pts[i+1][1])

-        _PolyLineInternal(pts)  # original
+        if mirrorX is None and mirrorY is None:
+            _PolyLineInternal(pts)  # original

-        if mirrorX is not None and mirrorY is not None:
+        elif mirrorX is not None and mirrorY is not None:
            self.TransformFlip(mirrorX, mirrorY, self.flipBoth)  # both
            _PolyLineInternal(pts)
            self.PopTransform()
--- a/pcbnew/python/plugins/bga_wizard.py
+++ b/pcbnew/python/plugins/bga_wizard.py
@ -163,7 +163,15 @@ class BGAWizard(FootprintWizardBase.FootprintWizard):
        self.draw.Value(0, ypos, text_size)
        self.draw.Reference(0, -ypos, text_size)

+        # Add a extra text (${REFERENCE}) on the F_Fab layer
+        extra_text = pcbnew.PCB_TEXT( self.module, pcbnew.PCB_TEXT.TEXT_is_DIVERS )
+        extra_text.SetLayer( pcbnew.F_Fab )
+        extra_text.SetPosition( pcbnew.VECTOR2I( 0, 0) )
+        extra_text.SetTextSize( pcbnew.VECTOR2I( text_size, text_size ) )
+        extra_text.SetText( "${REFERENCE}" )
+        self.module.Add( extra_text )
+
        # set SMD attribute
-        self.module.SetAttributes(pcbnew.PAD_ATTRIB_SMD)
+        self.module.SetAttributes(pcbnew.FP_SMD)

 BGAWizard().register()
--- a/pcbnew/python/plugins/microMatch_connectors.py
+++ b/pcbnew/python/plugins/microMatch_connectors.py
@ -136,7 +136,7 @@ class MicroMaTchWizard(FPWbase.FootprintWizard):
        # Use value to fill the modules description
        desc = self.GetValue()
        self.module.SetDescription(desc)
-        self.module.SetAttributes(1)
+        self.module.SetAttributes( pcbnew.FP_SMD )

        # add in the pads
        pad = self.GetPad()
--- a/pcbnew/python/plugins/mutualcap_button_wizard.py
+++ b/pcbnew/python/plugins/mutualcap_button_wizard.py
@ -1,4 +1,5 @@
 #  Copyright 2019-2020 Julian Fellinger
+#  Copyright (C) 2023 KiCad Developers.
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@ -17,7 +18,6 @@

 import FootprintWizardBase
 import pcbnew
-from pcbnew import *

 class MutualcapButtonWizard(FootprintWizardBase.FootprintWizard):

@ -55,10 +55,10 @@ class MutualcapButtonWizard(FootprintWizardBase.FootprintWizard):

    # build a rectangular pad
    def smdRectPad(self,module,size,pos,name):
-        pad = PAD(module)
+        pad = pcbnew.PAD(module)
        pad.SetSize(size)
-        pad.SetShape(PAD_SHAPE_RECT)
-        pad.SetAttribute(PAD_ATTRIB_SMD)
+        pad.SetShape(pcbnew.PAD_SHAPE_RECT)
+        pad.SetAttribute(pcbnew.PAD_ATTRIB_SMD)

        layerset = pcbnew.LSET()
        layerset.AddLayer(pcbnew.F_Cu)
@ -86,7 +86,7 @@ class MutualcapButtonWizard(FootprintWizardBase.FootprintWizard):
        clearance    = oew/2

        ###border h
-        self.module.SetLayer(F_Cu)
+        self.module.SetLayer(pcbnew.F_Cu)
        size_pad = pcbnew.VECTOR2I( w, oew )
        self.module.Add(self.smdRectPad(self.module,size_pad,
                                        pcbnew.VECTOR2I(0, (int)((-h/2)+oew/2) ),
@ -129,8 +129,24 @@ class MutualcapButtonWizard(FootprintWizardBase.FootprintWizard):
        self.draw.Value(0, h/2+textSize, textSize)
        self.draw.Reference(0, -h/2-textSize, textSize)

+        # Add a extra text (${REFERENCE}) on the F_Fab layer
+        extra_text = pcbnew.PCB_TEXT( self.module, pcbnew.PCB_TEXT.TEXT_is_DIVERS )
+        extra_text.SetLayer( pcbnew.F_Fab )
+        extra_text.SetPosition( pcbnew.VECTOR2I( 0, 0) )
+        extra_text.SetTextSize( pcbnew.VECTOR2I( textSize, textSize ) )
+        extra_text.SetText( "${REFERENCE}" )
+        self.module.Add( extra_text )
+
        #optionally draw silkscreen line around button
        if(drawBox):
-            self.draw.Box(0,0,w,h)
+            self.draw.SetLayer( pcbnew.F_SilkS )
+            self.draw.SetLineThickness( pcbnew.FromMM( 0.12 ) )     #Default per KLC F5.3
+            self.draw.Box( 0, 0, w, h )
+
+        # draw coutyard  around button
+        self.draw.SetLayer( pcbnew.F_CrtYd )
+        self.draw.SetLineThickness( pcbnew.FromMM( 0.05 ) )     #Default per KLC F5.3
+        margin = pcbnew.FromMM( 0.25 )  #Default per KLC F5.3
+        self.draw.Box( 0, 0, w + margin*2 , h + margin*2 )

 MutualcapButtonWizard().register()
--- a/pcbnew/python/plugins/qfn_wizard.py
+++ b/pcbnew/python/plugins/qfn_wizard.py
@ -227,7 +227,7 @@ class QFNWizard(FootprintWizardBase.FootprintWizard):
        self.draw.Reference(0, -text_offset, text_size)

        # set SMD attribute
-        self.module.SetAttributes(pcbnew.PAD_ATTRIB_SMD)
+        self.module.SetAttributes(pcbnew.FP_SMD)

 QFNWizard().register()

--- a/pcbnew/python/plugins/qfp_wizard.py
+++ b/pcbnew/python/plugins/qfp_wizard.py
@ -166,6 +166,6 @@ class QFPWizard(FootprintWizardBase.FootprintWizard):
        self.draw.Reference(0, -text_offset, text_size)

        # set SMD attribute
-        self.module.SetAttributes(pcbnew.PAD_ATTRIB_SMD)
+        self.module.SetAttributes(pcbnew.FP_SMD)

 QFPWizard().register()
--- a/pcbnew/python/plugins/sdip_wizard.py
+++ b/pcbnew/python/plugins/sdip_wizard.py
@ -132,9 +132,9 @@ class RowedFootprint(FootprintWizardBase.FootprintWizard):

        # set the attribute
        if self.GetName() == "S-DIP":
-            self.module.SetAttributes(pcbnew.PAD_ATTRIB_PTH)
+            self.module.SetAttributes(pcbnew.FP_PTH)
        elif self.GetName() == "SOIC":
-            self.module.SetAttributes(pcbnew.PAD_ATTRIB_SMD)
+            self.module.SetAttributes(pcbnew.FP_SMD)

 class SDIPWizard(RowedFootprint):

--- a/pcbnew/python/plugins/touch_slider_wizard.py
+++ b/pcbnew/python/plugins/touch_slider_wizard.py
@ -187,7 +187,7 @@ class TouchSliderWizard(FootprintWizardBase.FootprintWizard):
        self.draw.Reference(0, -ypos, t_size)

        # set SMD attribute
-        self.module.SetAttributes(PAD_ATTRIB_SMD)
+        self.module.SetAttributes(FP_SMD)

        # starting pad
        band_width = touch_width/bands
--- a/pcbnew/python/plugins/zip_wizard.py
+++ b/pcbnew/python/plugins/zip_wizard.py
@ -113,9 +113,9 @@ class RowedFootprint(FootprintWizardBase.FootprintWizard):

        # set SMD attribute
        if self.GetName() == "ZIP":
-            self.module.SetAttributes(pcbnew.PAD_ATTRIB_PTH)
+            self.module.SetAttributes(pcbnew.FP_PTH)
        elif self.GetName() == "ZOIC":
-            self.module.SetAttributes(pcbnew.PAD_ATTRIB_SMD)
+            self.module.SetAttributes(pcbnew.FP_SMD)

    def DrawBox(self, sizex, sizey):