Remove a leaky wx/msgdlg.h include

3d-viewer/3d_viewer/eda_3d_viewer.cpp

@@ -25,6 +25,7 @@
 #include <wx/colordlg.h>
 #include <wx/colour.h>
 #include <wx/filename.h>
+#include <wx/msgdlg.h>
 #include <wx/string.h>
 #include <wx/wupdlock.h>
 #include <wx/clipbrd.h>

cvpcb/auto_associate.cpp

@@ -40,6 +40,7 @@
 #include <cvpcb_mainframe.h>
 #include <listboxes.h>
 #include <project/project_file.h>
+#include <wx/msgdlg.h>
 
 #define QUOTE   '\''
 

include/board_item.h

@@ -33,8 +33,6 @@
 #include <layers_id_colors_and_visibility.h>
 #include <geometry/geometry_utils.h>
 
-#include <wx/msgdlg.h>
-
 class BOARD;
 class BOARD_ITEM_CONTAINER;
 class SHAPE_POLY_SET;
@@ -291,10 +289,7 @@ public:
      * @param aRotCentre the rotation point.
      * @param aAngle the rotation angle in 0.1 degree.
      */
-    virtual void Rotate( const wxPoint& aRotCentre, double aAngle )
-    {
-        wxMessageBox( wxT( "virtual BOARD_ITEM::Rotate used, should not occur" ), GetClass() );
-    }
+    virtual void Rotate( const wxPoint& aRotCentre, double aAngle );
 
     void Rotate( const VECTOR2I& aRotCentre, double aAngle )
     {
@@ -307,10 +302,7 @@ public:
      * @param aCentre the rotation point.
      * @param aFlipLeftRight mirror across Y axis instead of X (the default).
      */
-    virtual void Flip( const wxPoint& aCentre, bool aFlipLeftRight )
-    {
-        wxMessageBox( wxT( "virtual BOARD_ITEM::Flip used, should not occur" ), GetClass() );
-    }
+    virtual void Flip( const wxPoint& aCentre, bool aFlipLeftRight );
 
     void Flip( const VECTOR2I& aCentre, bool aFlipLeftRight )
     {

pcbnew/board_item.cpp

@@ -29,6 +29,8 @@
 #include <i18n_utility.h>
 #include <board.h>
 #include <string>
+#include <wx/msgdlg.h>
+
 
 wxString BOARD_ITEM::ShowShape( PCB_SHAPE_TYPE aShape )
 {
@@ -162,6 +164,18 @@ std::shared_ptr<SHAPE> BOARD_ITEM::GetEffectiveShape( PCB_LAYER_ID aLayer ) cons
 }
 
 
+void BOARD_ITEM::Rotate( const wxPoint& aRotCentre, double aAngle )
+{
+    wxMessageBox( wxT( "virtual BOARD_ITEM::Rotate used, should not occur" ), GetClass() );
+}
+
+
+void BOARD_ITEM::Flip( const wxPoint& aCentre, bool aFlipLeftRight )
+{
+    wxMessageBox( wxT( "virtual BOARD_ITEM::Flip used, should not occur" ), GetClass() );
+}
+
+
 static struct BOARD_ITEM_DESC
 {
     BOARD_ITEM_DESC()

pcbnew/dialogs/dialog_create_array.cpp

@@ -28,6 +28,7 @@
 #include <board.h>
 #include <footprint.h>
 #include <pcb_edit_frame.h>
+#include <wx/msgdlg.h>
 
 #include <boost/algorithm/string/join.hpp>
 

pcbnew/dialogs/dialog_dimension_properties.cpp

@@ -24,6 +24,7 @@
 #include <pcb_base_edit_frame.h>
 #include <pcb_layer_box_selector.h>
 #include <widgets/unit_binder.h>
+#include <wx/msgdlg.h>
 
 #include "dialog_dimension_properties.h"
 

pcbnew/exporters/export_idf.cpp

@@ -35,6 +35,7 @@
 #include <fp_shape.h>
 #include <idf_parser.h>
 #include <build_version.h>
+#include <wx/msgdlg.h>
 #include "project.h"
 #include "kiway.h"
 #include "3d_cache/3d_cache.h"

pcbnew/exporters/export_vrml.cpp

@@ -29,6 +29,7 @@
 #include <iomanip>
 #include <vector>
 #include <wx/dir.h>
+#include <wx/msgdlg.h>
 
 #include "3d_cache/3d_cache.h"
 #include "3d_cache/3d_info.h"

pcbnew/footprint_wizard_frame_functions.cpp

@@ -37,6 +37,7 @@
 #include <base_units.h>
 #include <widgets/wx_grid.h>
 #include <wx/listbox.h>
+#include <wx/msgdlg.h>
 
 #include <tool/tool_manager.h>
 

pcbnew/import_gfx/dialog_import_gfx.cpp

@@ -34,6 +34,7 @@
 #include <map>
 #include "dxf_import_plugin.h"
 #include <wx/filedlg.h>
+#include <wx/msgdlg.h>
 
 #include <memory>
 

pcbnew/netlist_reader/netlist.cpp

@@ -46,6 +46,7 @@ using namespace std::placeholders;
 #include <tools/pcb_actions.h>
 #include <tools/pcb_selection_tool.h>
 #include <project/project_file.h>  // LAST_PATH_TYPE
+#include <wx/msgdlg.h>
 
 
 extern void SpreadFootprints( std::vector<FOOTPRINT*>* aFootprints, wxPoint aSpreadAreaPosition );

pcbnew/python/scripting/pcbnew_action_plugins.cpp

@@ -32,6 +32,7 @@
 #include <pcbnew_settings.h>
 #include <tool/action_menu.h>
 #include <tool/action_toolbar.h>
+#include <wx/msgdlg.h>
 #include "../../scripting/python_scripting.h"
 
 PYTHON_ACTION_PLUGIN::PYTHON_ACTION_PLUGIN( PyObject* aAction )

pcbnew/python/scripting/pcbnew_footprint_wizards.cpp

@@ -30,6 +30,7 @@
 #include "pcbnew_footprint_wizards.h"
 #include <cstdio>
 #include <macros.h>
+#include <wx/msgdlg.h>
 #include "../../scripting/python_scripting.h"
 
 

pcbnew/undo_redo.cpp

@@ -44,6 +44,7 @@ using namespace std::placeholders;
 #include <tools/pcb_control.h>
 #include <tools/board_editor_control.h>
 #include <drawing_sheet/ds_proxy_undo_item.h>
+#include <wx/msgdlg.h>
 
 /* Functions to undo and redo edit commands.
  *  commands to undo are stored in CurrentScreen->m_UndoList