Fix X3D model parser.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10385

(cherry picked from commit 44e4abde0e)

plugins/3d/vrml/x3d/x3d_appearance.cpp

@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2016 Cirilo Bernardo <cirilo.bernardo@gmail.com>
- * Copyright (C) 2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2021-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -232,9 +232,14 @@ SGNODE* X3DAPP::TranslateToSG( SGNODE* aParent )
 {
     S3D::SGTYPES ptype = S3D::GetSGNodeType( aParent );
 
-    wxCHECK_MSG( aParent && ( ptype == S3D::SGTYPE_SHAPE ), nullptr,
-                 wxString::Format( wxT( "Appearance does not have a Shape parent (parent ID: %d)" ),
-                                   ptype ) );
+    if( nullptr != aParent && ptype != S3D::SGTYPE_SHAPE )
+    {
+        wxLogTrace( traceVrmlPlugin,
+                    wxT( " * [BUG] Appearance does not have a Shape parent (parent ID: %d)" ),
+                    ptype );
+
+        return nullptr;
+    }
 
     wxLogTrace( traceVrmlPlugin,
                 wxT( " * [INFO] Translating Appearance node with %zu children, %zu"

plugins/3d/vrml/x3d/x3d_ifaceset.cpp

@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2016 Cirilo Bernardo <cirilo.bernardo@gmail.com>
- * Copyright (C) 2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2021-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -227,10 +227,14 @@ SGNODE* X3DIFACESET::TranslateToSG( SGNODE* aParent )
 {
     S3D::SGTYPES ptype = S3D::GetSGNodeType( aParent );
 
-    wxCHECK_MSG( aParent && ( ptype == S3D::SGTYPE_SHAPE ), nullptr,
-                 wxString::Format( wxT( "IndexedFaceSet does not have a valid Shape parent "
-                                        "(parent ID: %d)" ),
-                                   ptype ) );
+    if( nullptr != aParent && ptype != S3D::SGTYPE_SHAPE )
+    {
+        wxLogTrace( traceVrmlPlugin,
+                    wxT( " * [BUG] IndexedFaceSet does not have a valid Shape parent "
+                         "(parent ID: %d)" ), ptype );
+
+        return nullptr;
+    }
 
     wxLogTrace( traceVrmlPlugin,
                 wxT( " * [INFO] Translating IndexedFaceSet with %zu children, %zu references, "

plugins/3d/vrml/x3d/x3d_shape.cpp

@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2016 Cirilo Bernardo <cirilo.bernardo@gmail.com>
- * Copyright (C) 2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2021-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -252,9 +252,14 @@ SGNODE* X3DSHAPE::TranslateToSG( SGNODE* aParent )
 
     S3D::SGTYPES ptype = S3D::GetSGNodeType( aParent );
 
-    wxCHECK_MSG( aParent && ( ptype == S3D::SGTYPE_TRANSFORM ), nullptr,
-                 wxString::Format( wxT( "Shape does not have a Transform parent (parent ID: %d)" ),
-                                   ptype ) );
+    if( nullptr != aParent && ptype != S3D::SGTYPE_TRANSFORM )
+    {
+        wxLogTrace( traceVrmlPlugin,
+                    wxT( " * [BUG] Shape does not have a Transform parent (parent ID: %d)" ),
+                    ptype );
+
+        return nullptr;
+    }
 
     if( m_sgNode )
     {

plugins/3d/vrml/x3d/x3d_transform.cpp

@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2016 Cirilo Bernardo <cirilo.bernardo@gmail.com>
- * Copyright (C) 2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2021-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -38,6 +38,7 @@ X3DTRANSFORM::X3DTRANSFORM() : X3DNODE()
     init();
 }
 
+
 X3DTRANSFORM::X3DTRANSFORM( X3DNODE* aParent ) : X3DNODE()
 {
     m_Type = X3D_TRANSFORM;
@@ -267,9 +268,14 @@ SGNODE* X3DTRANSFORM::TranslateToSG( SGNODE* aParent )
 
     S3D::SGTYPES ptype = S3D::GetSGNodeType( aParent );
 
-    wxCHECK_MSG( aParent && ( ptype == S3D::SGTYPE_TRANSFORM ), nullptr,
-                 wxString::Format( wxT( "Transform does not have a Transform parent "
-                                        "(parent ID: %d)" ), ptype ) );
+    if( nullptr != aParent && ptype != S3D::SGTYPE_TRANSFORM )
+    {
+        wxLogTrace( traceVrmlPlugin,
+                    wxT( " * [BUG] Transform does not have a Transform parent (parent ID: %d)" ),
+                    ptype );
+
+        return nullptr;
+    }
 
     if( m_sgNode )
     {