Remove call that crashes MySQL connector sometimes

It no longer is necessary anyway Fixes https://gitlab.com/kicad/code/kicad/-/issues/12471
3 years ago · 201b45b41a
1 changed files with 2 additions and 6 deletions
--- a/common/database/database_connection.cpp
+++ b/common/database/database_connection.cpp
@ -453,10 +453,7 @@ bool DATABASE_CONNECTION::SelectAll( const std::string& aTable, std::vector<ROW>

    try
    {
-        if( !results.first() )
-            return false;
-
-        do
+        while( results.next() )
        {
            ROW result;

@ -467,8 +464,7 @@ bool DATABASE_CONNECTION::SelectAll( const std::string& aTable, std::vector<ROW>
            }

            aResults.emplace_back( std::move( result ) );
-
-        } while( results.next() );
+        }
    }
    catch( nanodbc::database_error& e )
    {