Browse Source

Clean up stale TODOs.

newinvert
Jeff Young 2 years ago
parent
commit
1ff36f23b8
  1. 2
      common/font/outline_font.cpp
  2. 2
      eeschema/sch_io/altium/sch_io_altium.cpp
  3. 1
      libs/core/utf8.cpp
  4. 3
      pcbnew/array_creator.cpp
  5. 6
      pcbnew/drc/drc_test_provider_edge_clearance.cpp
  6. 5
      pcbnew/drc/drc_test_provider_text_dims.cpp
  7. 1
      pcbnew/pcb_edit_frame.cpp

2
common/font/outline_font.cpp

@ -86,8 +86,6 @@ FT_Error OUTLINE_FONT::loadFace( const wxString& aFontFileName, int aFaceIndex )
{ {
std::lock_guard<std::mutex> guard( m_freeTypeMutex ); std::lock_guard<std::mutex> guard( m_freeTypeMutex );
// TODO: check that going from wxString to char* with UTF-8
// conversion for filename makes sense on any/all platforms
FT_Error e = FT_New_Face( m_freeType, aFontFileName.mb_str( wxConvUTF8 ), aFaceIndex, &m_face ); FT_Error e = FT_New_Face( m_freeType, aFontFileName.mb_str( wxConvUTF8 ), aFaceIndex, &m_face );
if( !e ) if( !e )

2
eeschema/sch_io/altium/sch_io_altium.cpp

@ -1451,8 +1451,6 @@ void SCH_IO_ALTIUM::AddTextBox( const ASCH_TEXT_FRAME *aElem )
break; break;
} }
// JEY TODO: word-wrap once KiCad supports wrapped text.
size_t fontId = static_cast<int>( aElem->FontID ); size_t fontId = static_cast<int>( aElem->FontID );
if( m_altiumSheet && fontId > 0 && fontId <= m_altiumSheet->fonts.size() ) if( m_altiumSheet && fontId > 0 && fontId <= m_altiumSheet->fonts.size() )

1
libs/core/utf8.cpp

@ -230,7 +230,6 @@ UTF8& UTF8::operator+=( unsigned w_ch )
} }
else else
{ {
//TODO: Remove wchar use. Replace with std::byte*
wchar_t wide_chr[2]; // buffer to store wide chars (UTF16) read from aText wchar_t wide_chr[2]; // buffer to store wide chars (UTF16) read from aText
wide_chr[1] = 0; wide_chr[1] = 0;
wide_chr[0] = w_ch; wide_chr[0] = w_ch;

3
pcbnew/array_creator.cpp

@ -163,9 +163,6 @@ void ARRAY_CREATOR::Invoke()
// Silently drop other items (such as footprint texts) from duplication // Silently drop other items (such as footprint texts) from duplication
break; break;
} }
// @TODO: we should merge zones. This is a bit tricky, because
// the undo command needs saving old area, if it is merged.
} }
// Add new items to selection (footprints in the selection will be reannotated) // Add new items to selection (footprints in the selection will be reannotated)

6
pcbnew/drc/drc_test_provider_edge_clearance.cpp

@ -38,12 +38,6 @@
Errors generated: Errors generated:
- DRCE_EDGE_CLEARANCE - DRCE_EDGE_CLEARANCE
- DRCE_SILK_EDGE_CLEARANCE - DRCE_SILK_EDGE_CLEARANCE
TODO:
- separate holes to edge check
- tester only looks for edge crossings. it doesn't check if items are inside/outside the board
area.
- pad test missing!
*/ */
class DRC_TEST_PROVIDER_EDGE_CLEARANCE : public DRC_TEST_PROVIDER_CLEARANCE_BASE class DRC_TEST_PROVIDER_EDGE_CLEARANCE : public DRC_TEST_PROVIDER_CLEARANCE_BASE

5
pcbnew/drc/drc_test_provider_text_dims.cpp

@ -159,9 +159,8 @@ bool DRC_TEST_PROVIDER_TEXT_DIMS::Run()
for( const std::unique_ptr<KIFONT::GLYPH>& glyph : *glyphs ) for( const std::unique_ptr<KIFONT::GLYPH>& glyph : *glyphs )
{ {
// Ensure the glyph is a OUTLINE_GLYPH
// for texts with overbar, it can be a STROKE_GLYPH
// TODO: perhaps test the overbar thickness.
// Ensure the glyph is a OUTLINE_GLYPH (for instance, overbars in outline
// font text are represented as STROKE_GLYPHs).
if( !glyph->IsOutline() ) if( !glyph->IsOutline() )
continue; continue;

1
pcbnew/pcb_edit_frame.cpp

@ -1470,7 +1470,6 @@ void PCB_EDIT_FRAME::SetActiveLayer( PCB_LAYER_ID aLayer )
void PCB_EDIT_FRAME::onBoardLoaded() void PCB_EDIT_FRAME::onBoardLoaded()
{ {
// JEY TODO: move this global to the board
ENUM_MAP<PCB_LAYER_ID>& layerEnum = ENUM_MAP<PCB_LAYER_ID>::Instance(); ENUM_MAP<PCB_LAYER_ID>& layerEnum = ENUM_MAP<PCB_LAYER_ID>::Instance();
layerEnum.Choices().Clear(); layerEnum.Choices().Clear();

Loading…
Cancel
Save