From 1997d8410eba4e7833362e79344c4041bc203ad6 Mon Sep 17 00:00:00 2001
From: Alex Shvartzkop <dudesuchamazing@gmail.com>
Date: Sat, 23 Nov 2024 14:03:02 +0300
Subject: [PATCH] Fix "CheckMenuItem() failed, item not in the menu?" assert in
 net inspector on MSW.

Menu items should be added to the menu first and then checked on MSW.
---
 pcbnew/widgets/pcb_net_inspector_panel.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pcbnew/widgets/pcb_net_inspector_panel.cpp b/pcbnew/widgets/pcb_net_inspector_panel.cpp
index d7848ab970..de15d76ac8 100644
--- a/pcbnew/widgets/pcb_net_inspector_panel.cpp
+++ b/pcbnew/widgets/pcb_net_inspector_panel.cpp
@@ -1328,14 +1328,14 @@ void PCB_NET_INSPECTOR_PANEL::OnConfigButton( wxCommandEvent& event )
     wxMenuItem* filterByNetName = new wxMenuItem( &menu, ID_FILTER_BY_NET_NAME,
                                                   _( "Filter by Net Name" ),
                                                   wxEmptyString, wxITEM_CHECK );
-    filterByNetName->Check( cfg.filter_by_net_name );
     menu.Append( filterByNetName );
+    filterByNetName->Check( cfg.filter_by_net_name );
 
     wxMenuItem* filterByNetclass = new wxMenuItem( &menu, ID_FILTER_BY_NETCLASS,
                                                    _( "Filter by Netclass" ),
                                                    wxEmptyString, wxITEM_CHECK );
-    filterByNetclass->Check( cfg.filter_by_netclass );
     menu.Append( filterByNetclass );
+    filterByNetclass->Check( cfg.filter_by_netclass );
 
     menu.AppendSeparator();
 
@@ -1349,8 +1349,8 @@ void PCB_NET_INSPECTOR_PANEL::OnConfigButton( wxCommandEvent& event )
     wxMenuItem* groupNetclass = new wxMenuItem( &menu, ID_GROUP_BY_NETCLASS,
                                                 _( "Group by Netclass" ),
                                                 wxEmptyString, wxITEM_CHECK );
-    groupNetclass->Check( m_group_by_netclass );
     menu.Append( groupNetclass );
+    groupNetclass->Check( m_group_by_netclass );
 
     menu.AppendSeparator();
 
@@ -1377,14 +1377,14 @@ void PCB_NET_INSPECTOR_PANEL::OnConfigButton( wxCommandEvent& event )
     wxMenuItem* showZeroNetPads = new wxMenuItem( &menu, ID_SHOW_ZERO_NET_PADS,
                                                   _( "Show Zero Pad Nets" ),
                                                   wxEmptyString, wxITEM_CHECK );
-    showZeroNetPads->Check( m_show_zero_pad_nets );
     menu.Append( showZeroNetPads );
+    showZeroNetPads->Check( m_show_zero_pad_nets );
 
     wxMenuItem* showUnconnectedNets = new wxMenuItem( &menu, ID_SHOW_UNCONNECTED_NETS,
                                                       _( "Show Unconnected Nets" ),
                                                       wxEmptyString, wxITEM_CHECK );
-    showUnconnectedNets->Check( m_show_unconnected_nets );
     menu.Append( showUnconnectedNets );
+    showUnconnectedNets->Check( m_show_unconnected_nets );
 
     menu.AppendSeparator();