From 13b7dd354c9860b9556170b5281c07b1ae5c4964 Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Thu, 22 Aug 2019 10:53:50 +0100
Subject: [PATCH] Fix tab order in pin properties dialog.

Fixes: lp:1840991
* https://bugs.launchpad.net/kicad/+bug/1840991
---
 eeschema/dialogs/dialog_lib_edit_pin.cpp | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/eeschema/dialogs/dialog_lib_edit_pin.cpp b/eeschema/dialogs/dialog_lib_edit_pin.cpp
index 563aeb56ba..7482ac4d19 100644
--- a/eeschema/dialogs/dialog_lib_edit_pin.cpp
+++ b/eeschema/dialogs/dialog_lib_edit_pin.cpp
@@ -33,7 +33,7 @@
 
 #include <dialog_lib_edit_pin.h>
 #include <confirm.h>
-
+#include <widgets/tab_traversal.h>
 
 DIALOG_LIB_EDIT_PIN::DIALOG_LIB_EDIT_PIN( LIB_EDIT_FRAME* parent, LIB_PIN* aPin ) :
     DIALOG_LIB_EDIT_PIN_BASE( parent ),
@@ -62,6 +62,19 @@ DIALOG_LIB_EDIT_PIN::DIALOG_LIB_EDIT_PIN( LIB_EDIT_FRAME* parent, LIB_PIN* aPin
     for ( unsigned ii = 0; ii < orientationNames.GetCount(); ii++ )
         m_choiceOrientation->Insert( orientationNames[ii], KiBitmap( orientationBitmaps[ii] ), ii );
 
+    KIUI::SetControlsTabOrder( {
+        m_textPinName,
+        m_textPinNumber,
+        m_choiceElectricalType,
+        m_choiceStyle,
+        m_posXCtrl,
+        m_posYCtrl,
+        m_choiceOrientation,
+        m_pinLengthCtrl,
+        m_nameSizeCtrl,
+        m_numberSizeCtrl
+    } );
+
     m_sdbSizerButtonsOK->SetDefault();
     SetInitialFocus( m_textPinName );