Browse Source

Minor code style fixes

pull/18/head
Jon Evans 3 months ago
parent
commit
0997205ffb
  1. 1
      pcbnew/api/api_handler_pcb.cpp
  2. 12
      pcbnew/pcb_group.cpp
  3. 1
      pcbnew/pcb_group.h

1
pcbnew/api/api_handler_pcb.cpp

@ -672,6 +672,7 @@ HANDLER_RESULT<GetItemsResponse> API_HANDLER_PCB::handleGetItemsById(
GetItemsResponse response;
std::vector<BOARD_ITEM*> items;
for( const kiapi::common::types::KIID& id : aCtx.Request.items() )
{
if( std::optional<BOARD_ITEM*> item = getItemById( KIID( id.value() ) ) )

12
pcbnew/pcb_group.cpp

@ -79,21 +79,17 @@ bool PCB_GROUP::Deserialize( const google::protobuf::Any &aContainer )
const_cast<KIID&>( m_Uuid ) = KIID( group.id().value() );
SetName( wxString( group.name().c_str(), wxConvUTF8 ) );
BOARD* board = GetBoard();
if( !board )
return false;
for ( const kiapi::common::types::KIID& itemId : group.items() )
for( const kiapi::common::types::KIID& itemId : group.items() )
{
KIID id( itemId.value() );
KIID id( itemId.value() );
BOARD_ITEM* item = board->ResolveItem( id, true );
if( item )
{
if( BOARD_ITEM* item = board->ResolveItem( id, true ) )
AddItem( item );
}
}
return true;

1
pcbnew/pcb_group.h

@ -57,7 +57,6 @@ public:
void Serialize( google::protobuf::Any &aContainer ) const override;
bool Deserialize( const google::protobuf::Any &aContainer ) override;
EDA_ITEM* AsEdaItem() override { return this; }
static inline bool ClassOf( const EDA_ITEM* aItem )

Loading…
Cancel
Save