You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

186 lines
7.0 KiB

6 years ago
  1. #
  2. # This program source code file is part of KICAD, a free EDA CAD application.
  3. #
  4. # Copyright (C) 2007-2020 Kicad Developers, see AUTHORS.txt for contributors.
  5. #
  6. # This program is free software; you can redistribute it and/or
  7. # modify it under the terms of the GNU General Public License
  8. # as published by the Free Software Foundation; either version 2
  9. # of the License, or (at your option) any later version.
  10. #
  11. # This program is distributed in the hope that it will be useful,
  12. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  14. # GNU General Public License for more details.
  15. #
  16. # You should have received a copy of the GNU General Public License
  17. # along with this program; if not, you may find one here:
  18. # http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
  19. # or you may search the http://www.gnu.org website for the version 2 license,
  20. # or you may write to the Free Software Foundation, Inc.,
  21. # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
  22. #
  23. # Only configure warnings for Clang and GCC
  24. if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" )
  25. include( CheckCXXCompilerFlag )
  26. # The SWIG-generated files tend to throw a lot of warnings, so
  27. # we do not add the warnings directly to the flags here but instead
  28. # keep track of them and add them to the flags later in a controlled manner
  29. # (that way we can not put any warnings on the SWIG-generated files)
  30. set( COMPILER_SUPPORTS_WARNINGS TRUE )
  31. # Establish -Wall early, so specialized relaxations of this may come
  32. # subsequently on the command line, such as in pcbnew/github/CMakeLists.txt
  33. set( WARN_FLAGS_C "-Wall" )
  34. set( WARN_FLAGS_CXX "-Wall" )
  35. # Warn about missing override specifiers
  36. CHECK_CXX_COMPILER_FLAG( "-Wsuggest-override" COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
  37. if( COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
  38. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wsuggest-override" )
  39. message( STATUS "Enabling warning -Wsuggest-override" )
  40. endif()
  41. # This is Clang's version of -Wsuggest-override
  42. CHECK_CXX_COMPILER_FLAG( "-Winconsistent-missing-override" COMPILER_SUPPORTS_WINCONSISTENT_MISSING_OVERRIDE )
  43. if( COMPILER_SUPPORTS_WINCONSISTENT_MISSING_OVERRIDE )
  44. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Winconsistent-missing-override" )
  45. message( STATUS "Enabling warning -Winconsistent-missing-override" )
  46. endif()
  47. # Warn on duplicated branches
  48. CHECK_CXX_COMPILER_FLAG( "-Wduplicated-branches" COMPILER_SUPPORTS_WDUPLICATED_BRANCHES )
  49. if( COMPILER_SUPPORTS_WDUPLICATED_BRANCHES )
  50. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wduplicated-branches" )
  51. message( STATUS "Enabling warning -Wduplicated-branches" )
  52. endif()
  53. # Warn on duplicated conditions
  54. CHECK_CXX_COMPILER_FLAG( "-Wduplicated-cond" COMPILER_SUPPORTS_WDUPLICATED_COND )
  55. if( COMPILER_SUPPORTS_WDUPLICATED_COND )
  56. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wduplicated-cond" )
  57. message( STATUS "Enabling warning -Wduplicated-cond" )
  58. endif()
  59. # Error on variable length arrays (gcc extension)
  60. CHECK_CXX_COMPILER_FLAG( "-Wvla" COMPILER_SUPPORTS_WVLA )
  61. if( COMPILER_SUPPORTS_WVLA )
  62. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Werror=vla" )
  63. message( STATUS "Enabling error for -Wvla" )
  64. endif()
  65. # Warn on implicit switch fallthrough
  66. CHECK_CXX_COMPILER_FLAG( "-Wimplicit-fallthrough" COMPILER_SUPPORTS_WIMPLICIT_FALLTHROUGH )
  67. if( COMPILER_SUPPORTS_WIMPLICIT_FALLTHROUGH )
  68. if( CMAKE_COMPILER_IS_GNUCXX )
  69. # GCC level 5 does not allow comments - mirrors the Clang warning
  70. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wimplicit-fallthrough=5" )
  71. else()
  72. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wimplicit-fallthrough" )
  73. endif()
  74. message( STATUS "Enabling warning -Wimplicit-fallthrough" )
  75. endif()
  76. # Error if there is a problem with function returns
  77. CHECK_CXX_COMPILER_FLAG( "-Wreturn-type" COMPILER_SUPPORTS_WRETURN_TYPE )
  78. if( COMPILER_SUPPORTS_WRETURN_TYPE )
  79. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Werror=return-type" )
  80. message( STATUS "Enabling error for -Wreturn-type" )
  81. endif()
  82. # Warn about shadowed variables
  83. CHECK_CXX_COMPILER_FLAG( "-Wshadow" COMPILER_SUPPORTS_WSHADOW )
  84. if( COMPILER_SUPPORTS_WSHADOW )
  85. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wshadow" )
  86. message( STATUS "Enabling warning -Wshadow" )
  87. endif()
  88. # Add additional warning flags to avoid signed/unsigned comparison
  89. CHECK_CXX_COMPILER_FLAG( "-Wsign-compare" COMPILER_SUPPORTS_WSIGN )
  90. if( COMPILER_SUPPORTS_WSIGN )
  91. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wsign-compare" )
  92. message( STATUS "Enabling warning -Wsign-compare" )
  93. endif()
  94. # Warn about missing initializers in construction
  95. CHECK_CXX_COMPILER_FLAG( "-Wmissing-field-initializers" COMPILER_SUPPORTS_WMISSING_INIT )
  96. if( COMPILER_SUPPORTS_WMISSING_INIT )
  97. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wmissing-field-initializers" )
  98. message( STATUS "Enabling warning -Wmissing-field-initializers" )
  99. endif()
  100. # Warn about empty if/for/while bodies
  101. CHECK_CXX_COMPILER_FLAG( "-Wempty-body" COMPILER_SUPPORTS_WEMPTY_BODY )
  102. if( COMPILER_SUPPORTS_WEMPTY_BODY )
  103. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wempty-body" )
  104. message( STATUS "Enabling warning -Wempty-body" )
  105. endif()
  106. # Warn about out of order intialization
  107. CHECK_CXX_COMPILER_FLAG( "-Wreorder" COMPILER_SUPPORTS_WREORDER )
  108. if( COMPILER_SUPPORTS_WREORDER )
  109. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wreorder" )
  110. message( STATUS "Enabling warning -Wreorder" )
  111. endif()
  112. # Warn about mismatched class/struct declarations
  113. CHECK_CXX_COMPILER_FLAG( "-Wmismatched-tags" COMPILER_SUPPORTS_WMISMATCHED_TAGS )
  114. if( COMPILER_SUPPORTS_WMISMATCHED_TAGS )
  115. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wmismatched-tags" )
  116. message( STATUS "Enabling warning -Wmismatched-tags" )
  117. endif()
  118. # See if the compiler will throw warnings on these conversions
  119. CHECK_CXX_COMPILER_FLAG( "-Wimplicit-int-float-conversion" COMPILER_SUPPORTS_WIMPLICIT_FLOAT_CONVERSION )
  120. if( COMPILER_SUPPORTS_WIMPLICIT_FLOAT_CONVERSION )
  121. # This one is different, it is used to guard warning removal for this inside the code
  122. set( HAVE_WIMPLICIT_FLOAT_CONVERSION true )
  123. endif()
  124. # Avoid ABI warnings, specifically one about an ABI change on ppc64el from gcc5 to gcc 6.
  125. CHECK_CXX_COMPILER_FLAG( "-Wpsabi" COMPILER_SUPPORTS_WPSABI )
  126. if( COMPILER_SUPPORTS_WPSABI )
  127. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wno-psabi" )
  128. message( STATUS "Disabling warning -Wpsabi" )
  129. endif()
  130. # Append any additional warning flags so the end of the warning string
  131. if( KICAD_ADDITIONAL_WARN_FLAGS )
  132. set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} ${KICAD_ADDITIONAL_WARN_FLAGS}" )
  133. message( STATUS "Adding additional warning flags: ${KICAD_ADDITIONAL_WARN_FLAGS}")
  134. endif()
  135. endif()