Browse Source

Fix amount error and external_id.

pull/904/head
James Cole 3 months ago
parent
commit
084b42ccb0
  1. 4
      app/Services/SimpleFIN/Conversion/TransactionTransformer.php
  2. 6
      config/simplefin.php

4
app/Services/SimpleFIN/Conversion/TransactionTransformer.php

@ -62,7 +62,7 @@ class TransactionTransformer
public function transform(array $transactionData, array $simpleFINAccountData, array $accountMapping = [], array $newAccountConfig = []): array
{
// Ensure amount is a float. SimpleFIN provides it as a string.
$amount = isset($transactionData['amount']) ? (float) $transactionData['amount'] : '0.0';
$amount = $transactionData['amount'] ?? '0.0';
// Skip zero-amount transactions as they're invalid for Firefly III
if(0 === bccomp('0', $amount)) {
@ -365,7 +365,7 @@ class TransactionTransformer
*/
private function buildExternalId(array $transactionData, array $simpleFINAccountData): string
{
return sprintf('simplefin-%s-%s', $simpleFINAccountData['id'] ?? 'unknown_account', $transactionData['id'] ?? 'unknown_transaction');
return sprintf('ff3-%s-%s', $simpleFINAccountData['id'] ?? 'unknown_account', $transactionData['id'] ?? 'unknown_transaction');
}
/**

6
config/simplefin.php

@ -57,11 +57,7 @@ return [
|--------------------------------------------------------------------------
*/
'unique_column_options' => [
'id' => 'Transaction ID',
'account_id' => 'Account ID',
'posted' => 'Posted Date',
'amount' => 'Amount',
'description' => 'Description',
'external-id' => 'External identifier',
],
/*

Loading…
Cancel
Save