Raymond Hettinger
a3626bc5bd
Issue #24583 : Fix crash when set is mutated while being updated.
11 years ago
Yury Selivanov
7aa5341164
Reverting my previous commit.
Something went horribly wrong when I was doing `hg rebase`.
11 years ago
Serhiy Storchaka
fa494fd883
Issue #24115 : Update uses of PyObject_IsTrue(), PyObject_Not(),
PyObject_IsInstance(), PyObject_RichCompareBool() and _PyDict_Contains()
to check for and handle errors correctly.
11 years ago
Raymond Hettinger
8651a50475
Issue #23359 : Specialize set_lookkey intoa lookup function and an insert function.
11 years ago
Raymond Hettinger
5af9e13c18
Minor stylistic and consistency cleanup.
11 years ago
Raymond Hettinger
1bd8d75be3
Issue #23290 : Optimize set_merge() for cases where the target is empty.
(Contributed by Serhiy Storchaka.)
11 years ago
Raymond Hettinger
438f9134cf
Mirco-optimizations to reduce register spills and reloads observed on CLANG and GCC.
11 years ago
Raymond Hettinger
8249282622
Minor code clean up.
11 years ago
Raymond Hettinger
06bb1226d1
Issue 23359: Reduce size of code in set_lookkey. Only do linear probes when there is no wrap-around.
Nice simplification contributed by Serhiy Storchaka :-)
11 years ago
Raymond Hettinger
c658d85487
Issue 23359: Tighten inner search loop for sets (don't and-mask every entry lookup).
11 years ago
Raymond Hettinger
59ecabd12a
Keep the definition of i consistent between set_lookkey() and set_insert_clean().
11 years ago
Raymond Hettinger
9edd753229
Minor tweak to improve code clarity.
11 years ago
Raymond Hettinger
06a1c8dfa0
Fix typo in a comment.
11 years ago
Raymond Hettinger
f8d1a31e70
Revert unintended part of the commit (the key==dummy test wasn't supposed to change).
11 years ago
Raymond Hettinger
a5ebbf6295
Remove unneeded dummy test from the set search loop (when the hashes match we know the key is not a dummy).
11 years ago
Raymond Hettinger
3037e84ad1
Issue #23269 : Tighten search_loop in set_insert_clean()
Instead of masking and shifting every loopup, move the wrap-around
test outside of the inner-loop.
11 years ago
Raymond Hettinger
b335dfe7fa
Set the hash values of dummy entries to -1. Improves quality of entry->hash == hash tests.
11 years ago
Raymond Hettinger
4d45c1069b
Update out-of-date comments.
11 years ago
Raymond Hettinger
93035c44fd
Issue #23119 : Simplify setobject by inlining the special case for unicode equality testing.
11 years ago
Raymond Hettinger
ed741d4ff0
A hybrid of and-masking and a conditional-set-to-zero produce even faster search loop.
11 years ago
Raymond Hettinger
bd9b200b87
Update copyright for 2015 updates.
11 years ago
Raymond Hettinger
9cd6a789c6
Clean-up, simplify, and slightly speed-up bounds logic in set_pop().
Elsewhere in the setobject.c code we do a bitwise-and with the mask
instead of using a conditional to reset to zero on wrap-around.
Using that same technique here use gives cleaner, faster, and more
consistent code.
11 years ago
Raymond Hettinger
1202a4733e
Issue 23261: Clean-up the hack to store the set.pop() search finger in a hash field instead of the setobject.
11 years ago
Raymond Hettinger
8edf27c134
Small clean-up. Factor-out common code for add, contains, and discard function pairs.
11 years ago
Raymond Hettinger
08e3dc0ad6
Issue #23107 : Tighten-up loops in setobject.c
* Move the test for an exact key match to after a hash match
* Use "used" as a loop counter instead of "fill"
* Minor improvements to variable names and code consistency
11 years ago
Victor Stinner
12174a5dca
Issue #22156 : Fix "comparison between signed and unsigned integers" compiler
warnings in the Objects/ subdirectory.
PyType_FromSpecWithBases() and PyType_FromSpec() now reject explicitly negative
slot identifiers.
12 years ago
Raymond Hettinger
426d9958a2
Add development comments to setobject.c
12 years ago
Eric V. Smith
6ba5665fc7
Fix typo in comment.
12 years ago
Raymond Hettinger
74fc8c47f6
Add comments to frozenset_hash().
Also, provide a minor hint to the compiler on how to group the xors.
12 years ago
Raymond Hettinger
e259f13874
Minor code clean-up. Keep the C-API all in one section.
12 years ago
Raymond Hettinger
710a67edfc
Note that LINEAR_PROBES can be set to zero.
13 years ago
Raymond Hettinger
4ef0528b97
Minor beautification. Put updates and declarations in a more logical order.
13 years ago
Raymond Hettinger
0ce1953bf7
When LINEAR_PROBES=0, let the compiler remove the dead code on its own.
13 years ago
Raymond Hettinger
c70a2b7bb9
Make the linear probe sequence clearer.
13 years ago
Raymond Hettinger
8408dc581e
Issue 18771: Make it possible to set the number linear probes at compile-time.
13 years ago
Raymond Hettinger
742d8716ff
Put the defines in the logical section and fix indentation.
13 years ago
Raymond Hettinger
583cd03fd1
Minor code beautification.
13 years ago
Raymond Hettinger
4ea9080da9
Improve code clarity by removing two unattractive macros.
13 years ago
Raymond Hettinger
8f8839e10a
Remove the freelist scheme for setobjects.
The setobject freelist was consuming memory but not providing much value.
Even when a freelisted setobject was available, most of the setobject
fields still needed to be initialized and the small table still required
a memset(). This meant that the custom freelisting scheme for sets was
providing almost no incremental benefit over the default Python freelist
scheme used by _PyObject_Malloc() in Objects/obmalloc.c.
13 years ago
Raymond Hettinger
04fd9dd52b
Small rearrangement to bring together the three functions for probing the hash table.
13 years ago
Raymond Hettinger
ae7b00e2d3
Move the overview comment to the top of the file.
13 years ago
Raymond Hettinger
c56e0e3980
Minor touchups.
13 years ago
Raymond Hettinger
69492dab07
Factor-out the common code for setting a KeyError.
13 years ago
Raymond Hettinger
a35adf5b09
Instead of XORed indicies, switch to a hybrid of linear probing and open addressing.
Modern processors tend to make consecutive memory accesses cheaper than
random probes into memory.
Small sets can fit into L1 cache, so they get less benefit. But they do
come out ahead because the consecutive probes don't probe the same key
more than once and because the randomization step occurs less frequently
(or not at all).
For the open addressing step, putting the perturb shift before the index
calculation gets the upper bits into play sooner.
13 years ago
Raymond Hettinger
6c3c1ccd1b
Update copyright.
13 years ago
Raymond Hettinger
95c0d67581
Further reduce the cost of hash collisions by inspecting an additional nearby entry.
13 years ago
Raymond Hettinger
afe890923f
Tighten-up the lookkey() logic and beautify the code a bit.
Use less code by moving many of the steps from the initial
lookup into the main search loop.
Beautify the code but keep the overall logic unchanged.
13 years ago
Antoine Pitrou
9d95254bb7
Issue #18772 : fix the gdb plugin after the set implementation changes
13 years ago
Raymond Hettinger
bfc1e1a9cd
Add the same dummy type that is used in dictionaries.
13 years ago
Raymond Hettinger
fcf3b500ba
Issue 18797: Remove unneeded refcount adjustments for dummy objects.
It suffices to keep just one reference when the object is created.
13 years ago