Browse Source

bpo-33907: Rename an IDLE module and classes. (GH-7810)

Fix-up class name duplication in PR #7807. Combined effect is that
module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w class CallTip is now CalltipWindow.
pull/7389/merge
Terry Jan Reedy 8 years ago
committed by GitHub
parent
commit
9af1836664
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      Lib/idlelib/calltip.py
  2. 8
      Lib/idlelib/calltip_w.py
  3. 4
      Lib/idlelib/idle_test/test_calltip_w.py
  4. 6
      Misc/NEWS.d/next/IDLE/2018-06-19-22-21-27.bpo-33907.z-_B3N.rst

4
Lib/idlelib/calltip.py

@ -31,7 +31,7 @@ class Calltip:
def _make_tk_calltip_window(self):
# See __init__ for usage
return calltip_w.Calltip(self.text)
return calltip_w.CalltipWindow(self.text)
def _remove_calltip_window(self, event=None):
if self.active_calltip:
@ -44,7 +44,7 @@ class Calltip:
return "break"
def try_open_calltip_event(self, event):
"""Happens when it would be nice to open a Calltip, but not really
"""Happens when it would be nice to open a calltip, but not really
necessary, for example after an opening bracket, so function calls
won't be made.
"""

8
Lib/idlelib/calltip_w.py

@ -1,4 +1,4 @@
"""A Calltip window class for Tkinter/IDLE.
"""A calltip window class for Tkinter/IDLE.
After tooltip.py, which uses ideas gleaned from PySol
Used by calltip.
@ -13,7 +13,7 @@ CHECKHIDE_TIME = 100 # milliseconds
MARK_RIGHT = "calltipwindowregion_right"
class Calltip:
class CalltipWindow:
def __init__(self, widget):
self.widget = widget
@ -47,7 +47,7 @@ class Calltip:
def showtip(self, text, parenleft, parenright):
"""Show the calltip, bind events which will close it and reposition it.
"""
# Only called in Calltip, where lines are truncated
# Only called in calltip.Calltip, where lines are truncated
self.text = text
if self.tipwindow or not self.text:
return
@ -147,7 +147,7 @@ def _calltip_window(parent): # htest #
text.pack(side=LEFT, fill=BOTH, expand=1)
text.insert("insert", "string.split")
top.update()
calltip = Calltip(text)
calltip = CalltipWindow(text)
def calltip_show(event):
calltip.showtip("(s=Hello world)", "insert", "end")

4
Lib/idlelib/idle_test/test_calltip_w.py

@ -6,7 +6,7 @@ from test.support import requires
from tkinter import Tk, Text
class CallTipTest(unittest.TestCase):
class CallTipWindowTest(unittest.TestCase):
@classmethod
def setUpClass(cls):
@ -14,7 +14,7 @@ class CallTipTest(unittest.TestCase):
cls.root = Tk()
cls.root.withdraw()
cls.text = Text(cls.root)
cls.calltip = calltip_w.Calltip(cls.text)
cls.calltip = calltip_w.CalltipWindow(cls.text)
@classmethod
def tearDownClass(cls):

6
Misc/NEWS.d/next/IDLE/2018-06-19-22-21-27.bpo-33907.z-_B3N.rst

@ -1,3 +1,3 @@
For consistency and appearance, rename an IDLE module and class. Module
idlelib.calltips is now calltip. Class idlelib.calltip_w.CallTip is now
Calltip.
For consistency and clarity, rename an IDLE module and classes.
Module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w, class CallTip is now CalltipWindow.
Loading…
Cancel
Save