Browse Source

Fix ResourceWarning in asyncio.BaseSubprocessTransport

Issue #24763: Fix resource warnings when asyncio.BaseSubprocessTransport
constructor fails, if subprocess.Popen raises an exception for example.

Patch written by Martin Richard, test written by me.
pull/224/head
Victor Stinner 11 years ago
parent
commit
6fb1e740c6
  1. 9
      Lib/asyncio/base_subprocess.py
  2. 15
      Lib/test/test_asyncio/test_subprocess.py

9
Lib/asyncio/base_subprocess.py

@ -35,8 +35,13 @@ class BaseSubprocessTransport(transports.SubprocessTransport):
self._pipes[2] = None
# Create the child process: set the _proc attribute
self._start(args=args, shell=shell, stdin=stdin, stdout=stdout,
stderr=stderr, bufsize=bufsize, **kwargs)
try:
self._start(args=args, shell=shell, stdin=stdin, stdout=stdout,
stderr=stderr, bufsize=bufsize, **kwargs)
except:
self.close()
raise
self._pid = self._proc.pid
self._extra['subprocess'] = self._proc

15
Lib/test/test_asyncio/test_subprocess.py

@ -1,6 +1,7 @@
import signal
import sys
import unittest
import warnings
from unittest import mock
import asyncio
@ -413,6 +414,20 @@ class SubprocessMixin:
# the transport was not notified yet
self.assertFalse(killed)
def test_popen_error(self):
# Issue #24763: check that the subprocess transport is closed
# when BaseSubprocessTransport fails
with mock.patch('subprocess.Popen') as popen:
exc = ZeroDivisionError
popen.side_effect = exc
create = asyncio.create_subprocess_exec(sys.executable, '-c',
'pass', loop=self.loop)
with warnings.catch_warnings(record=True) as warns:
with self.assertRaises(exc):
self.loop.run_until_complete(create)
self.assertEqual(warns, [])
if sys.platform != 'win32':
# Unix

Loading…
Cancel
Save