bpo-30961: Fix decrementing a borrowed reference in tracemalloc. (#2747)

9 years ago · 4ed5ad79ec
2 changed files with 2 additions and 2 deletions
--- a/Misc/NEWS.d/next/Library/2017-07-18-23-47-51.bpo-30961.064jz0.rst
+++ b/Misc/NEWS.d/next/Library/2017-07-18-23-47-51.bpo-30961.064jz0.rst
@ -0,0 +1 @@
+Fix decrementing a borrowed reference in tracemalloc.
--- a/Modules/_tracemalloc.c
+++ b/Modules/_tracemalloc.c
@ -1752,7 +1752,7 @@ _PyTraceMalloc_Init(void)
        if (key == NULL)
            return -1;

-        value = PyDict_GetItemWithError(xoptions, key);
+        value = PyDict_GetItemWithError(xoptions, key); /* borrowed */
        Py_DECREF(key);
        if (value == NULL) {
            if (PyErr_Occurred())
@ -1763,7 +1763,6 @@ _PyTraceMalloc_Init(void)
        }

        nframe = parse_sys_xoptions(value);
-        Py_DECREF(value);
        if (nframe < 0) {
            Py_FatalError("-X tracemalloc=NFRAME: invalid number of frames");
        }