Fix a possible reference leak in _socket.getaddrinfo(). (GH-10543)

"single" needs to be decrefed if PyList_Append() fails.
7 years ago · 4c596d54aa
1 changed files with 4 additions and 2 deletions
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@ -6370,9 +6370,11 @@ socket_getaddrinfo(PyObject *self, PyObject *args, PyObject* kwargs)
        if (single == NULL)
            goto err;

-        if (PyList_Append(all, single))
+        if (PyList_Append(all, single)) {
+            Py_DECREF(single);
            goto err;
-        Py_XDECREF(single);
+        }
+        Py_DECREF(single);
    }
    Py_XDECREF(idna);
    if (res0)