Browse Source

bpo-42195: Disallow isinstance/issubclass for subclasses of genericaliases in Union (GH-24059)

Previously this didn't raise an error. Now it will:
```python
from collections.abc import Callable
isinstance(int, list | Callable[..., str])
```
Also added tests in Union since there were previously none for stuff like ``isinstance(list, list | list[int])`` either.

Backport to 3.9 not required.

Automerge-Triggered-By: GH:gvanrossum
pull/24064/head
Ken Jin 5 years ago
committed by GitHub
parent
commit
49cd68fb1e
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 10
      Lib/test/test_types.py
  2. 2
      Objects/unionobject.c

10
Lib/test/test_types.py

@ -737,6 +737,16 @@ class TypesTests(unittest.TestCase):
with self.assertRaises(ZeroDivisionError):
list[int] | list[bt]
union_ga = (int | list[str], int | collections.abc.Callable[..., str],
int | d)
# Raise error when isinstance(type, type | genericalias)
for type_ in union_ga:
with self.subTest(f"check isinstance/issubclass is invalid for {type_}"):
with self.assertRaises(TypeError):
isinstance(list, type_)
with self.assertRaises(TypeError):
issubclass(list, type_)
def test_ellipsis_type(self):
self.assertIsInstance(Ellipsis, types.EllipsisType)

2
Objects/unionobject.c

@ -34,7 +34,7 @@ is_generic_alias_in_args(PyObject *args) {
Py_ssize_t nargs = PyTuple_GET_SIZE(args);
for (Py_ssize_t iarg = 0; iarg < nargs; iarg++) {
PyObject *arg = PyTuple_GET_ITEM(args, iarg);
if (Py_TYPE(arg) == &Py_GenericAliasType) {
if (PyObject_TypeCheck(arg, &Py_GenericAliasType)) {
return 0;
}
}

Loading…
Cancel
Save