Browse Source
bpo-40287: Fix SpooledTemporaryFile.seek() return value (GH-19540)
It has not returned the file position after the seek.
pull/19569/head
Inada Naoki
6 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with
6 additions and
3 deletions
-
Lib/tempfile.py
-
Lib/test/test_tempfile.py
-
Misc/NEWS.d/next/Library/2020-04-15-17-21-48.bpo-40287.-mkEJH.rst
|
|
|
@ -738,7 +738,7 @@ class SpooledTemporaryFile: |
|
|
|
return self._file.readlines(*args) |
|
|
|
|
|
|
|
def seek(self, *args): |
|
|
|
self._file.seek(*args) |
|
|
|
return self._file.seek(*args) |
|
|
|
|
|
|
|
def tell(self): |
|
|
|
return self._file.tell() |
|
|
|
|
|
|
|
@ -1018,7 +1018,8 @@ class TestSpooledTemporaryFile(BaseTestCase): |
|
|
|
# Verify writelines with a SpooledTemporaryFile |
|
|
|
f = self.do_create() |
|
|
|
f.writelines((b'x', b'y', b'z')) |
|
|
|
f.seek(0) |
|
|
|
pos = f.seek(0) |
|
|
|
self.assertEqual(pos, 0) |
|
|
|
buf = f.read() |
|
|
|
self.assertEqual(buf, b'xyz') |
|
|
|
|
|
|
|
@ -1036,7 +1037,8 @@ class TestSpooledTemporaryFile(BaseTestCase): |
|
|
|
# when that occurs |
|
|
|
f = self.do_create(max_size=30) |
|
|
|
self.assertFalse(f._rolled) |
|
|
|
f.seek(100, 0) |
|
|
|
pos = f.seek(100, 0) |
|
|
|
self.assertEqual(pos, 100) |
|
|
|
self.assertFalse(f._rolled) |
|
|
|
f.write(b'x') |
|
|
|
self.assertTrue(f._rolled) |
|
|
|
|
|
|
|
@ -0,0 +1 @@ |
|
|
|
Fixed ``SpooledTemporaryFile.seek()`` to return the position. |