Browse Source

bpo-35720: Fixing a memory leak in pymain_parse_cmdline_impl() (GH-11528)

When the loop in the pymain_read_conf function in this same file
calls pymain_init_cmdline_argv() a 2nd time, the pymain->command
buffer of wchar_t is overriden and the previously allocated memory
is never freed.
pull/11650/head
Lucas Cimon 7 years ago
committed by Victor Stinner
parent
commit
35ca1820e1
  1. 1
      Misc/NEWS.d/next/Core and Builtins/2019-01-12-23-33-04.bpo-35720.LELKQx.rst
  2. 1
      Modules/main.c

1
Misc/NEWS.d/next/Core and Builtins/2019-01-12-23-33-04.bpo-35720.LELKQx.rst

@ -0,0 +1 @@
Fixed a minor memory leak in pymain_parse_cmdline_impl function in Modules/main.c

1
Modules/main.c

@ -1376,6 +1376,7 @@ pymain_read_conf(_PyMain *pymain, _PyCoreConfig *config,
goto done;
}
pymain_clear_cmdline(pymain, cmdline);
pymain_clear_pymain(pymain);
memset(cmdline, 0, sizeof(*cmdline));
config->utf8_mode = new_utf8_mode;
config->coerce_c_locale = new_coerce_c_locale;

Loading…
Cancel
Save