Browse Source

bpo-43149: Improve error message for exception group without parentheses (GH-24467)

pull/24477/head
Pablo Galindo 6 years ago
committed by GitHub
parent
commit
206cbdab16
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 11
      Grammar/python.gram
  2. 33
      Lib/test/test_syntax.py
  3. 2
      Misc/NEWS.d/next/Core and Builtins/2021-02-07-03-27-14.bpo-43149.0umPKD.rst
  4. 917
      Parser/parser.c

11
Grammar/python.gram

@ -201,9 +201,10 @@ try_stmt[stmt_ty]:
| 'try' &&':' b=block f=finally_block { _Py_Try(b, NULL, NULL, f, EXTRA) }
| 'try' &&':' b=block ex[asdl_excepthandler_seq*]=except_block+ el=[else_block] f=[finally_block] { _Py_Try(b, ex, el, f, EXTRA) }
except_block[excepthandler_ty]:
| 'except' e=expression t=['as' z=NAME { z }] &&':' b=block {
| 'except' e=expression t=['as' z=NAME { z }] ':' b=block {
_Py_ExceptHandler(e, (t) ? ((expr_ty) t)->v.Name.id : NULL, b, EXTRA) }
| 'except' &&':' b=block { _Py_ExceptHandler(NULL, NULL, b, EXTRA) }
| 'except' ':' b=block { _Py_ExceptHandler(NULL, NULL, b, EXTRA) }
| invalid_except_block
finally_block[asdl_stmt_seq*]: 'finally' ':' a=block { a }
return_stmt[stmt_ty]:
@ -737,3 +738,9 @@ invalid_import_from_targets:
invalid_with_stmt:
| [ASYNC] 'with' ','.(expression ['as' star_target])+ &&':'
| [ASYNC] 'with' '(' ','.(expressions ['as' star_target])+ ','? ')' &&':'
invalid_except_block:
| 'except' a=expression ',' expressions ['as' NAME ] ':' {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "exception group must be parenthesized") }
| 'except' expression ['as' NAME ] &&':'
| 'except' &&':'

33
Lib/test/test_syntax.py

@ -835,6 +835,39 @@ Make sure that the old "raise X, Y[, Z]" form is gone:
...
SyntaxError: invalid syntax
Check that an exception group with missing parentheses
raise a custom exception
>>> try:
... pass
... except A, B:
... pass
Traceback (most recent call last):
SyntaxError: exception group must be parenthesized
>>> try:
... pass
... except A, B, C:
... pass
Traceback (most recent call last):
SyntaxError: exception group must be parenthesized
>>> try:
... pass
... except A, B, C as blech:
... pass
Traceback (most recent call last):
SyntaxError: exception group must be parenthesized
>>> try:
... pass
... except A, B, C as blech:
... pass
... finally:
... pass
Traceback (most recent call last):
SyntaxError: exception group must be parenthesized
>>> f(a=23, a=234)
Traceback (most recent call last):

2
Misc/NEWS.d/next/Core and Builtins/2021-02-07-03-27-14.bpo-43149.0umPKD.rst

@ -0,0 +1,2 @@
Improve the error message in the parser for exception groups without
parentheses. Patch by Pablo Galindo.

917
Parser/parser.c
File diff suppressed because it is too large
View File

Loading…
Cancel
Save